remove hw acceleration

README.md

@@ -18,10 +18,6 @@ Future releases will improve this aspect accepting API keys instead.
 ### Setup FFmpeg
 To run the importer it is necessary to download [FFmpeg](https://ffmpeg.org/download.html) locally, and copy the binary file into the default folder "\FFmpeg", or specify its location with arguments.
 
-### Setup CUDA Toolkit (optional)
-To use hardware acceleration with CUDA is necessary to install [CUDA Toolkit](https://developer.nvidia.com/cuda-toolkit).  
-Moreover, is necessary to use an FFmpeg version compiled with support to hardware acceleration.
-
 ### How to use
 
 **EthernaVideoImporter's help**
@@ -35,7 +31,6 @@ Source types:
 
 Options:
   -ff   Path FFmpeg (default dir: .\FFmpeg\)
-  -hw   Use hardware acceleration on FFmpeg (default: none). Valid values: [none, cuda]
   -t    TTL (days) Postage Stamp (default value: 365 days)
   -o    Offer video downloads to everyone
   -p    Pin videos
@@ -62,7 +57,6 @@ Usage:  EthernaVideoImporter.Devcon md MD_FOLDER [OPTIONS]
 
 Options:
   -ff   Path FFmpeg (default dir: .\FFmpeg\)
-  -hw   Use hardware acceleration on FFmpeg (default: none). Valid values: [none, cuda]
   -t    TTL (days) Postage Stamp (default value: 365 days)
   -o    Offer video downloads to everyone
   -p    Pin videos

src/EthernaVideoImporter.Core/Options/EncoderServiceOptions.cs

@@ -1,5 +1,4 @@
-using Etherna.VideoImporter.Core.Models.Domain;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.IO;
 
 namespace Etherna.VideoImporter.Core.Options
@@ -9,7 +8,6 @@ public sealed class EncoderServiceOptions
         // Properties.
         public string FFMpegBinaryPath => Path.Combine(FFMpegFolderPath, CommonConsts.FFMpegBinaryName);
         public string FFMpegFolderPath { get; set; } = CommonConsts.DefaultFFmpegFolder;
-        public FFMpegHwAccelerations FFMpegHwAcceleration { get; set; } = FFMpegHwAccelerations.None;
         public bool IncludeAudioTrack { get; set; }
         public bool Skip360 { get; set; }
         public bool Skip480 { get; set; }

src/EthernaVideoImporter.Core/Services/EncoderService.cs

@@ -100,31 +100,19 @@ private void AppendOutputFFmpegCommandArgs(List<string> args, int height, int wi
             args.Add("-c:a"); args.Add("aac");
 
             //video codec
-            args.Add("-c:v"); args.Add(options.FFMpegHwAcceleration switch
-            {
-                FFMpegHwAccelerations.None => "libx264",
-                FFMpegHwAccelerations.Cuda => "h264_nvenc",
-                _ => throw new InvalidOperationException()
-            });
+            args.Add("-c:v"); args.Add("libx264");
 
             //flags
             args.Add("-movflags"); args.Add("faststart");
 
             //filters
             args.Add("-vf");
             {
-                var filters = new List<string>();
-
-                //scale
-                switch (options.FFMpegHwAcceleration)
+                var filters = new List<string>
                 {
-                    case FFMpegHwAccelerations.Cuda:
-                        filters.Add($"scale_cuda=w={width}:h={height}");
-                        break;
-                    default:
-                        filters.Add($"scale=w={width}:h={height}");
-                        break;
-                }
+                    //scale
+                    $"scale=w={width}:h={height}"
+                };
 
                 args.Add($"{filters.Aggregate((r, f) => $"{r},{f}")}");
             }
@@ -152,16 +140,6 @@ private IEnumerable<string> BuildFFmpegCommandArgs(
             var resolutionRatio = (decimal)sourceVideoFile.Width / sourceVideoFile.Height;
             var outputsList = new List<(string filePath, int height, int width)>();
 
-            //hw acceleration
-            switch (options.FFMpegHwAcceleration)
-            {
-                case FFMpegHwAccelerations.Cuda:
-                    args.Add("-hwaccel"); args.Add("cuda");
-                    args.Add("-hwaccel_output_format"); args.Add("cuda");
-                    break;
-                default: break;
-            }
-
             //input
             args.Add("-i"); args.Add(sourceVideoFile.FilePath);
 

src/EthernaVideoImporter.Devcon/Program.cs

@@ -41,7 +41,6 @@ internal static class Program
             "\n" +
             "Options:\n" +
             $"  -ff\tPath FFmpeg (default dir: {CommonConsts.DefaultFFmpegFolder})\n" +
-            $"  -hw\tUse hardware acceleration on FFmpeg (default: {nameof(FFMpegHwAccelerations.None).ToLowerInvariant()}). Valid values: [{Enum.GetNames<FFMpegHwAccelerations>().Aggregate((r, i) => $"{r}, {i}").ToLowerInvariant()}]\n" +
             $"  -t\tTTL (days) Postage Stamp (default value: {VideoUploaderServiceOptions.DefaultTtlPostageStamp.TotalDays} days)\n" +
             "  -o\tOffer video downloads to everyone\n" +
             "  -p\tPin videos\n" +
@@ -89,7 +88,6 @@ static async Task Main(string[] args)
             bool skip480 = false;
             bool skip360 = false;
             bool useBeeNativeNode = false;
-            var ffMpegHwAcceleration = FFMpegHwAccelerations.None;
 
             // Parse input.
             if (args.Length == 0)
@@ -175,7 +173,6 @@ static async Task Main(string[] args)
                     case "-skip720": skip720 = true; break;
                     case "-skip480": skip480 = true; break;
                     case "-skip360": skip360 = true; break;
-                    case "-hw": ffMpegHwAcceleration = Enum.Parse<FFMpegHwAccelerations>(args[++i], true); break;
                     default: throw new ArgumentException(args[i] + " is not a valid argument");
                 }
             }
@@ -237,7 +234,6 @@ static async Task Main(string[] args)
                 {
                     if (customFFMpegFolderPath is not null)
                         encoderOptions.FFMpegFolderPath = customFFMpegFolderPath;
-                    encoderOptions.FFMpegHwAcceleration = ffMpegHwAcceleration;
                     encoderOptions.IncludeAudioTrack = includeAudioTrack;
                     encoderOptions.Skip1440 = skip1440;
                     encoderOptions.Skip1080 = skip1080;

src/EthernaVideoImporter/Program.cs

@@ -47,7 +47,6 @@ internal static class Program
             "\n" +
             "Options:\n" +
             $"  -ff\tPath FFmpeg (default dir: {CommonConsts.DefaultFFmpegFolder})\n" +
-            $"  -hw\tUse hardware acceleration on FFmpeg (default: {nameof(FFMpegHwAccelerations.None).ToLowerInvariant()}). Valid values: [{Enum.GetNames<FFMpegHwAccelerations>().Aggregate((r, i) => $"{r}, {i}").ToLowerInvariant()}]\n" +
             $"  -t\tTTL (days) Postage Stamp (default value: {VideoUploaderServiceOptions.DefaultTtlPostageStamp.TotalDays} days)\n" +
             "  -o\tOffer video downloads to everyone\n" +
             "  -p\tPin videos\n" +
@@ -96,7 +95,6 @@ static async Task Main(string[] args)
             bool skip480 = false;
             bool skip360 = false;
             bool useBeeNativeNode = false;
-            var ffMpegHwAcceleration = FFMpegHwAccelerations.None;
 
             // Parse input.
             if (args.Length == 0)
@@ -198,7 +196,6 @@ static async Task Main(string[] args)
                     case "-skip720": skip720 = true; break;
                     case "-skip480": skip480 = true; break;
                     case "-skip360": skip360 = true; break;
-                    case "-hw": ffMpegHwAcceleration = Enum.Parse<FFMpegHwAccelerations>(args[++i], true); break;
                     default: throw new ArgumentException(args[i] + " is not a valid argument");
                 }
             }
@@ -259,7 +256,6 @@ static async Task Main(string[] args)
                 {
                     if (customFFMpegFolderPath is not null)
                         encoderOptions.FFMpegFolderPath = customFFMpegFolderPath;
-                    encoderOptions.FFMpegHwAcceleration = ffMpegHwAcceleration;
                     encoderOptions.IncludeAudioTrack = includeAudioTrack;
                     encoderOptions.Skip1440 = skip1440;
                     encoderOptions.Skip1080 = skip1080;