This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Made github-repo-access-refresh runnable as a job #10935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging in with GitHub was taking notably longer than other SSO methods because it was performing a refresh of the user's Github repo access. Made a new service to call this function that can be run as a job, and running it as a job on Kubernetes. createExecutorJob now has an optional param to not wait for the job to finish before resolving for this and similar situations where you don't care to check if the job is finished. Default is to waitForFinish to be true.
barankyle
requested review from
hanzlamateen,
DanielBelmes,
MoizAdnan,
hurairahmateen and
aditya-mitra
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logging in with GitHub was taking notably longer than other SSO methods because it was performing a refresh of the user's Github repo access. Made a new service to call this function that can be run as a job, and running it as a job on Kubernetes.
createExecutorJob now has an optional param to not wait for the job to finish before resolving for this and similar situations where you don't care to check if the job is finished. Default is to waitForFinish to be true.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps