Update to Minecraft 1.20.6

[JRoy]

this compiles and probably works but there is some things still left to do

• test banner itemdb
• fix potion itemdb (see todos)
• update item aliases

[ImDarkLaw]

Overall, changes look good. I noticed, however, that the following exception is still being printed in console when using /give. Perhaps that'd be something to address (or wait for Paper to resolve) before merging?

[00:27:06 ERROR]: [org.bukkit.craftbukkit.util.CraftMagicNumbers] null
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

[Luftwaffle46]

com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

[JRoy]

com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

the exception is unrelated to this and it is a (harmless) bukkit bug, nothing essentials can quite control.

[LOOHP]

com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

the exception is unrelated to this and it is a (harmless) bukkit bug, nothing essentials can quite control.

I've encountered this with my plugin when I used Bukkit.getUnsafe().modifyItemStack. Apparently, we have to include the item type in the arguments to avoid this error in 1.20.6.

For example, this prints the CommandSyntaxException error:

Bukkit.getUnsafe().modifyItemStack(head, "[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]");

This does not:

Bukkit.getUnsafe().modifyItemStack(head, "minecraft:player_head[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]");

Previously, in 1.20.4, we did not need to include the item type:

Bukkit.getUnsafe().modifyItemStack(head, "{SkullOwner: {Properties: {textures: [{Value: \"" + base64 + "\"}]}}}");

Most likely this is already known by Essentials devs but I thought I'd leave it here if anyone else is looking up this problem.

[Budderman18]

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

[ImDarkLaw]

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

[Budderman18]

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

i am on the latest version of that branch and it still occurs.

Server version: 1.20.6-R0.1-SNAPSHOT 1.20.6-89-d3ffa62 (MC: 1.20.6)
Brand version: Paper
EssentialsX version: 2.21.0-dev+91-6bbc4a6

[JRoy]

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

i am on the latest version of that branch and it still occurs.

Server version: 1.20.6-R0.1-SNAPSHOT 1.20.6-89-d3ffa62 (MC: 1.20.6)
Brand version: Paper
EssentialsX version: 2.21.0-dev+91-6bbc4a6

when the server is stopped, delete the items.json file in the plugins/Essentials folder. When you start it, the issue should be resolved.

This will happen automatically once merged