Check for the specific modifier instead of last char in string #5638
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5495.
Details
Proposed fix:
This PR fixes half of the issue presented.
It is also more simplistic and a much better approach compared to my previous PR
Instead of checking for the last character in the string ->
Character.toLowerCase(ogStr.charAt(ogStr.length() - 1))
,check for the exact modified being use via removing the amount from the string ->
ogStr.replace(sanitizedString, "")
If the result of
ogStr.replace(sanitizedString, "")
is not exactly one of the modifiers, throw an exception (unless an empty string is returned due to a modifier not being present).Environments tested:
OS: Linux 5.15.0-79-generic
Java version: java 19.0.1
Demonstration: