Fix particles not being hidden, infinite time #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
false -> true; actually hides the particles Integer.MAX_VALUE -> (int) Double.POSITIVE_INFINITY; Since 1.20 allows the value of infinite to be set for the potion time
|
Please see #5509 (comment). |
mdcfe
added
the
status: waiting on author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5509 .
Details
Proposed fix:
false->true; actually hides the particlesInteger.MAX_VALUE->(int) Double.POSITIVE_INFINITY; Since 1.20 allows the value of infinite to be set for the potion timethis.getBase().addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 1, false));->this.getBase().addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, (int) Double.POSITIVE_INFINITY, 1, true));Essentials/Essentials/src/main/java/com/earth2me/essentials/User.java
Line 989 in b900444
https://github.com/Cats1337/Essentials/blob/b900444ff0b84a35574671e92674d323b86f503e/Essentials/src/main/java/com/earth2me/essentials/User.java#L989
Environments tested:
OS: Windows
Java version: 17
Demonstration: