Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nickname regex configurable #5200

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Nickname regex configurable #5200

wants to merge 2 commits into from

Conversation

Angelillo15
Copy link

Information

Details

Proposed feature:

Make /nick regex editable

Environments tested:

OS: Windows 11 22H2

Java version: 11.0.6

  • Most recent Paper version (1.19.3, git-Paper-365)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

Before you can put a name for example with a "." and the only solution was to give the permission: essentials.nick.allowunsafe

Now you can edit it in the config:

YanisBft
YanisBft approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@YanisBft YanisBft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful addition, but in my opinion the config should be clearer. Like it could be named allowed-nicks-regex for instance.

@pop4959 pop4959 added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels May 5, 2023
@SrBedrock
Copy link
Contributor

Very necessary for servers that accept Bedrock players with Geyser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanisBft YanisBft YanisBft approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Angelillo15 @SrBedrock @YanisBft @pop4959