Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanish uses incorrect potion attributes #5509

Closed
Cats1337 opened this issue Sep 8, 2023 · 4 comments · May be fixed by #5510
Closed

Vanish uses incorrect potion attributes #5509

Cats1337 opened this issue Sep 8, 2023 · 4 comments · May be fixed by #5510
Labels
bug: unconfirmed Potential bugs that need replicating to verify. status: not enough info Issues that require more information to be provided, either by the author or through investigation.

Comments

@Cats1337
Copy link

Cats1337 commented Sep 8, 2023

Type of bug

Other unexpected behaviour

/ess dump all output

https://essentialsx.net/dump.html?id=28b0028769fb47038ced378ea0d1caff

Error log (if applicable)

No response

Bug description

this.getBase().addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 1, false));
false shows effect particles making the vanished player visible to anyone paying attention. Since 1.20 allows the value of infinite to be set for the potion time setting MAX_VALUE still displays the effect icon whereas infinite doesn't

Steps to reproduce

  1. /vanish, /v, /ev, /evanish, etc.
  2. Potion Particles appear
  3. Potion icon appears on screen

Expected behaviour

The player should be entirely invisible without particle effects, and no clutter of potion icons on the screen.

Actual behaviour

The player's Invisibility particles appear, and the time is just set to an integer limit
@Cats1337 Cats1337 added the bug: unconfirmed Potential bugs that need replicating to verify. label Sep 8, 2023
@Cats1337 Cats1337 mentioned this issue Sep 8, 2023
Open
3 tasks
@mdcfe
Copy link
Member

mdcfe commented Sep 8, 2023

Potion particles are intended to be visible to players who can see vanished players. Could you clarify how your permissions were set up when you tested this?

@pop4959 pop4959 added the status: not enough info Issues that require more information to be provided, either by the author or through investigation. label Sep 12, 2023
@Cats1337
Copy link
Author

Sorry for the delayed response. Potion particles should just be hidden, I've had people without permission able to see my particles. The other things is just the time can be applied as Infinite now.

@pop4959
Copy link
Member

pop4959 commented Sep 28, 2023

No worries, thanks for responding. To clarify, Essentials only adds a potion effect to the vanished player when the permission essentials.vanish.effect is granted. It is implied that you are giving this permission if you are seeing this.

If you believe there is a bug, please run /lp verbose <username> & essentials.vanish and see what permissions are being checked to confirm whether it is configured properly.

@pop4959
Copy link
Member

pop4959 commented Oct 2, 2023

Closing this for now; if you believe this is still a bug let us know. It's most likely just permission related though.

@pop4959 pop4959 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: unconfirmed Potential bugs that need replicating to verify. status: not enough info Issues that require more information to be provided, either by the author or through investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix particles not being hidden, infinite time Cats1337/Essentials
3 participants
@mdcfe @pop4959 @Cats1337