Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: Thank you very much for this fork of architectury-loom!
However, I have found a few issues related to 1.13.2 - it just did not want to work properly.
After some tinkering around with various configurations, I found the culprits:
For this to work, the new implementation relies on the
spec
version (for some older Forge 1.13.2 versions we need to hack it to2
, though).Furthermore, during this whole process I found that the LZMA files that are being generated by legacy configurations are "damaged" - this is due to ning/jvm-compressor-benchmark#1, which is referenced in jponge/lzma-java#9.
Since
org.tukaani:xz:1.8
was already a (probably runtime (?)) dependency, I removedlzma-java
and migrated the code toxz
, which does not have any issues with silenced OOMs anymore.