refactor(openClose): use the correct property to specify open/close transition prop #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor to be ignored
github-actions
bot
added
the
bug
jcfranco
changed the title
github-actions
bot
added
the
refactor
jcfranco
added
the
skip visual snapshots
Elijbet
approved these changes
Jan 15, 2025
| @@ -38,7 +37,7 @@ export interface OpenCloseComponent { | |||
| } | |||
|
|
|||
| function isOpen(component: OpenCloseComponent): boolean { | |||
| return "opened" in component ? component.opened : component.open; | |||
| return component[component.openProp || "open"]; | |||
There was a problem hiding this comment.
Great! This will cover expanded/collapsed/closed states as well.
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Updates open/close components to use the correct transition property.
Notes
openPropoptional and defaults toopenwhen not specifiedtransitionPropopenTransitionProptoopenPropto avoid confusion with CSS transitions@Elijbet Thanks for spotting this one!