Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(autocomplete, input, input-text): update pattern context for residing in a parent form #11285

Merged
merged 1 commit into from
Jan 15, 2025
Merged

docs(autocomplete, input, input-text): update pattern context for residing in a parent form #11285

merged 1 commit into from
Jan 15, 2025
+6 −3

Conversation

geospatialem
Copy link
Member

Related Issue: #11148

Summary

Updates the pattern prop in autocomplete, input, and input-text that to use the prop the component must reside within a form element, re: #11148 (comment).

@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 13, 2025
@geospatialem geospatialem self-assigned this Jan 13, 2025
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Jan 13, 2025
DitwanP
DitwanP approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@DitwanP DitwanP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

benelan
benelan approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@benelan benelan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! FYI other constraint validation properties like required, max, min, max-length, and min-length also need be associated with a form.

@geospatialem
Copy link
Member Author

Nice! FYI other constraint validation properties like required, max, min, max-length, and min-length also need be associated with a form.

Appreciate the context, I'll open a new PR to follow-up on the above.

@geospatialem geospatialem merged commit 2bb1ef5 into dev Jan 15, 2025
15 of 16 checks passed
@geospatialem geospatialem deleted the geospatialem--docs-pattern branch January 15, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DitwanP DitwanP DitwanP approved these changes

@benelan benelan benelan approved these changes

Assignees

@geospatialem geospatialem

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@geospatialem @benelan @DitwanP