Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(combobox): avoid emitting change event for value property update #11281

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jan 13, 2025

Related Issue: #8970

Summary

Adds the following E2E tests for combobox:

  • should not emit calciteComboboxChange event when value attribute is updated
  • should not emit calciteComboboxItemChange event when selected attribute is toggled

@anveshmekala anveshmekala added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 13, 2025
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@anveshmekala anveshmekala merged commit 42ec590 into dev Jan 22, 2025
10 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/8970-combobox-avoid-change-event branch January 22, 2025 16:38
benelan added a commit that referenced this pull request Jan 24, 2025
* origin/dev: (34 commits)
  build: update browserslist db (#11339)
  build(deps): update dependency lint-staged to v15.4.1 (#11343)
  chore: release next
  feat(graph): add component tokens (#11355)
  chore: release next
  fix(popover, tooltip): drop relative-positioning to reduce risk of clipping (#11373)
  chore: release next
  fix(date-picker): no longer disable min/max value month in select menu (#11350)
  chore(icon): improve icon load error message (#11367)
  fix(date-picker): remove outline for header actions (#11369)
  chore: release next
  fix(carousel): Ensure correct `autoplay` display and animation (#11338)
  chore: release next
  fix(flow): process items on loaded (#11364)
  chore: release next
  fix(combobox, stepper, table): respect user hidden attribute (#10983)
  refactor(action-pad): restore rounded styling (#11358)
  test(combobox): avoid emitting change event for value property update (#11281)
  chore: release next
  refactor(action-pad): remove unnecessary overflow css styling. (#11349)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants