Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): add icon leads notification for calcite-ui-icons requests #11263

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

geospatialem
Copy link
Member

Related Issue: #9922

Summary

Add automation to issues when the calcite-ui-icons label is added, where Icon team leads will receive an @ notification via a comment, similar to the new component label automation from the notifyAboutNewComponent script.

cc @allieorth, @arowles

@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 10, 2025
@geospatialem geospatialem self-assigned this Jan 10, 2025
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 10, 2025
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are tagging icon designers in a comment instead of assigning them (or the @Esri/calcite-icon-designers team) to the issue? I think designers would be notified either way, but it assigning would reduce noise for the issue author.

Edit: Actually you can't assign a team to an issue. But assigning the individual designer(s) is still an option.

.github/workflows/issue-notifications.yaml Show resolved Hide resolved
.github/scripts/notifyAboutIconRequest.js Outdated Show resolved Hide resolved
@geospatialem
Copy link
Member Author

Why are tagging icon designers in a comment instead of assigning them (or the @Esri/calcite-icon-designers team) to the issue? I think designers would be notified either way, but it assigning would reduce noise for the issue author.

Edit: Actually you can't assign a team to an issue. But assigning the individual designer(s) is still an option.

If we'd rather assign issues to the team, can alter the automation - the intent was to be similar to our new component and spike complete notifications, where:

  • Icon leads would be notified and could review the request
  • If the Icon team would like to proceed with the request, they could assign themselves to follow-up with the requestor once the icon(s) are added
  • If the Icon team does not wish to proceed with the request, the issue would be closed with a response to the requestor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants