Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to the Swift4.2(Xcode10 beta6) #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated to the Swift4.2(Xcode10 beta6) #490

wants to merge 1 commit into from

Conversation

shanyanhai
Copy link

@shanyanhai shanyanhai commented Sep 3, 2018

in code:
Fix Any warning
Fix emoji judge
Known issues : traverse enum is failure
in Test :
String does not belong to NSObject and does not have the classname attribute.(location: testClassName)

testClassName

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

in code:
Fix Any warning
Fix emoji judge
Known  issues : traverse  enum is failure
in Test :
String does not belong to NSObject and does not have the classname attribute.(location: testClassName)

testClassName
@EZSwiftExtensionsBot
Copy link

5 Errors
🚫 Please, modify only one extension per pull request.
🚫 Sources/EZSwiftFunctions.swift#L81: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
🚫 Sources/EZSwiftFunctions.swift#L90: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
🚫 Sources/ArrayExtensions.swift#L26: cannot convert value of type ‘CountableRange<Array.Index>’ (aka ‘CountableRange<Int>’) to expected argument type ‘Range<Int>’
let halfOpenClampedRange = Range(range).clamped(to: indices)
🚫 Sources/ArrayExtensions.swift#L117: value of type ‘EnumeratedSequence<[Element]>’ has no member ‘compactMap’
return enumerated().compactMap { ($0.element == element) ? $0.offset : nil }

Generated by 🚫 Danger

@shanyanhai
Copy link
Author

shanyanhai commented Sep 3, 2018

Please use the Xcode Version 10.0, supporter Swift 4.2.
No major logical changes,Swift4.2:Many enums class names have been changed,
if modify only one extension per pull request.Time consuming.

@ceeyang
Copy link

ceeyang commented Sep 28, 2018

@shanyanhai
Hi there, Is there any way to pod your updated branch to my project?

@shanyanhai
Copy link
Author

@shanyanhai
Hi there, Is there any way to pod your updated branch to my project?
pod 'EZSwiftExtensions', :git => 'https://github.com/shanyanhai/EZSwiftExtensions.git', :branch => 'Swift4.2'

@isimple4
Copy link

@shanyanhai You should update travis configuration to specify Xcode version. And maybe Xcode 10 GM is a better choice rather than a beta version.

@ceeyang
Copy link

ceeyang commented Sep 28, 2018

@shanyanhai Thanks very much. You did me a big favor.

@shanyanhai
Copy link
Author

@shanyanhai Thanks very much. You did me a big favor.

Xcode (10A254a) ---OK ,
I'm using.
I don't know how to update Travis configuration /:wipe

@Khalian
Copy link
Collaborator

Khalian commented Nov 12, 2018

Cross check the official effort here : #496. I think I covered all your changes here and made further progress on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants