Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): [clangsa][clang-tidy] Fix dead doc_urls in checker labels #4214

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

whisperity
Copy link
Member

@whisperity whisperity commented Apr 12, 2024

Fix the URLs for checkers which are no longer available upstream. Changes created mostly by applying #4207 and some manual review following that.

I deleted the checkers from the configuration which seemingly never existed in a release:

  • Clang-Tidy cppcoreguidelines-avoid-capture-default-when-capturing-this was introduced in llvm/llvm-project@8a8f77c, but subsequently removed and renamed as cppcoreguidelines-misleading-capture-default-by-value in llvm/llvm-project@eedbe81. Both of these commits happened between llvmorg-17-init (17.trunk branch-off) and llvmorg-17.0.0-rc1, thus there isn't a valid release that contained this check under this name.
  • Clang-Tidy linuxkernel-must-use-errs. This checker never actually existed under this name, even though the documentation was previously extant at https://clang.llvm.org/extra/clang-tidy/checks/linuxkernel/must-use-errs.html. The checker was introduced in llvm/llvm-project@fc8c65b with the file name MustCheckErrs[Check.(cpp|h)] and checker name linuxkernel-must-check-errs (this is the name used in Tidy!), but with the broken documentation "name" linuxkernel-must-use-errs. Thus, the name of the checker and the name of the documentation does not line up.

@whisperity whisperity added this to the release 6.24.0 milestone Apr 12, 2024
@whisperity whisperity force-pushed the chore/config/doc-url-dead-links branch from 6cb5db3 to da973bb Compare April 12, 2024 18:23
@whisperity whisperity marked this pull request as ready for review April 12, 2024 18:29
@whisperity whisperity marked this pull request as draft April 12, 2024 18:38
@whisperity whisperity force-pushed the chore/config/doc-url-dead-links branch from da973bb to 334ddca Compare April 12, 2024 18:56
@whisperity whisperity marked this pull request as ready for review April 12, 2024 18:57
@bruntib bruntib merged commit 1cc23c7 into Ericsson:master Apr 25, 2024
7 of 9 checks passed
@whisperity whisperity deleted the chore/config/doc-url-dead-links branch April 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants