chore: latest common package and move /api to baseUrl
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
commented
Nov 15, 2024
| @@ -30,7 +30,7 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api 'cloud.eppo:sdk-common-jvm:3.5.0' | |||
| api 'cloud.eppo:sdk-common-jvm:3.5.2' | |||
There was a problem hiding this comment.
Will rerun tests and merge only after common package is published
typotter
requested review from
aarsilv and
felipecsl
and removed request for
aarsilv
felipecsl
approved these changes
Nov 15, 2024
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| ```groovy | |||
| dependencies { | |||
| implementation 'cloud.eppo:eppo-server-sdk:3.1.0' | |||
| implementation 'cloud.eppo:eppo-server-sdk:4.0.1' | |||
aarsilv
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards FF-3558
🎟️ FF-3558
Motivation and Context
Most, nearly all in fact, of the SDKs use a baseUrl of https://fscdn.eppo.cloud/api and endpoint constants of
/flag-config/v1/configand/flag-config/v1/banditsfor flag and bandit requests.iOS and, at some point, the Java SDK stopped following this convention instead putting the /apiportion in the endpoint string.
All of the SDKs need to follow the common convention in order for our cross-SDK testing tools (scenario testing, benchmarking) to work seamlessly.