Fix display bug when selecting a date range #2942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs relating to the v4 will be closed and locked.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...). If this is a fix, please tag a bug.
Bug fix
What is the current behavior? (You can also link to an open issue here)
When using a picker with selectable date range, the CSS class "range-in" for dates between the selected- and hovered date are not shown for hovered dates after the selected date.
Furthermore the "range-start" and "range-end" CSS classes are not toggled correctly (as in they should turn around when hovering before or after the already selected date).
What is the new behavior (if this is a feature change)?
While only the start date is selected, the dates between it and the hovered date should now correctly apply, regardless of if the hovered date is before, after, or not even in the same calendar view.
When selecting a date range, the start and end date should now face the correct direction depending on if the hovered date is before or after the already selected date.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
There should not be any breaking changes as this is purely a fix to already existing features.
Other information:
Stackblitz