Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ::{{closure}} in more cases from function names #230

Merged
merged 6 commits into from
Aug 6, 2024
+9 −4
Merged

Remove ::{{closure}} in more cases from function names #230

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fda37c
Support any number of clouser depth
Hoodad Aug 5, 2024
2d56bd2
Removed comment
Hoodad Aug 5, 2024
4e8027f
Merge branch 'main' into hoodad/fix-cleaning-of-functions
Hoodad Aug 5, 2024
325becf
cargo fmt
Hoodad Aug 5, 2024
93f2de3
Updated documentation for profile_function
Hoodad Aug 6, 2024
2235b3c
cargo fmt
Hoodad Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions puffin/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// The macro defines 'f()' at the place where macro is called.
// This code is located at the place of call and two closures deep.
// This code is typically located at the place of call and two closures deep.
// Strip away this useless suffix.
pub(crate) const USELESS_SCOPE_NAME_SUFFIX: &str = "::{{closure}}::{{closure}}::f";
pub(crate) const USELESS_SCOPE_NAME_SUFFIX: &str = "::f";
pub(crate) const USELESS_CLOSURE_SUFFIX: &str = "::{{closure}}";

#[doc(hidden)]
#[inline(never)]
Expand All @@ -10,7 +11,8 @@ pub fn clean_function_name(name: &str) -> String {
// Probably the user registered a user scope name.
return name.to_owned();
};
shorten_rust_function_name(name)
// Remove any additional trailing suffixes
shorten_rust_function_name(name.trim_end_matches(USELESS_CLOSURE_SUFFIX))
}

/// Shorten a rust function name by removing the leading parts of module paths.
Expand Down
Loading