Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pending frame list to GlobalFrameView #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zoxc
Copy link

@Zoxc Zoxc commented Oct 7, 2023

This adds a pending frame list to GlobalFrameView. It's used if the lock for the FrameView is not available at the moment. This may happen if puffin_egui is rendering while new_frame is called on a different thread. In that case, this change prevents the puffin_egui from blocking the other thread.

puffin_egui also currently deadlocks as it holds the lock for the FrameView while also having profiling scopes, making a cycle with the GlobalProfiler. This change removes that deadlock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant