New run.sh, README.md and dockerfile optimizations #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
azapater
commented
Jul 24, 2024
azapater
commented
- Removed files pull_run.sh, pull_run_production.sh and run_production.sh
- Multiple arguments to execute run.sh with default values defined (execute run.sh -h for help)
- Dockerfile variables for PA_SERVER_URL and PA_SERVER_VERSION
- The build.sh created the image with default securepass password while the ARG was defaulted to securepass
- Dockerfile optimizations for a smaller size and better stagging/caching approach
- Fully rewritten README.md
- Updated logos
- New build.sh script for better maintainability and tagging
- Clean up on scripts for readability
- Changed the shell to #!/usr/bin/env bash for better standardization. - Refactor all the installation commands in a new install.sh. - Optimized the Dockerfile to remove unnecessary layers, reducing the image size considerably. - Exposed the path /root/PAServer/scratch-dir for an immutable image and easy access to binaries. - Added new environment variables for better future maintainability in scripts. - Updated the syntax from CMD to ENTRYPOINT as CMD is deprecated. - Removed the platform specification from run.sh as it was unnecessary. - Added a container name to run.sh to avoid random naming and duplication of containers.
- Dockerfile variables for PA_SERVER_URL and PA_SERVER_VERSION - The build.sh created the image with default securepass password while the ARG was defaulted to securepass - Dockerfile optimizations - link fixed to dockerhub in README.md - updated logo of RAD - clean up on scripts for readability
* new simplied run.sh - removed files pull_run, pull_run_production, run_production - specifically pulling images from dockerhub is innecesary: docker does it automatically if the image is not in the local registry - multiple arguments to execute run.sh with default values defined - execute run.sh -h for this help -- Usage: run.sh [OPTIONS] Example 1: run.sh --path /home/user/ --detach --port 64211 --production --password securepass --name my-paserver --version latest Example 2: run.sh -pa /home/user/ -d -p 64211 -pr -pw securepass -n my-paserver -v latest Options: --detach, -d Run in detached mode - default: false --path, -pa Binds the container to a local folder - default: no bind --port, -p=PORT Specify the port to use be used by PAServer - default: 64211 --production, -pr Enable production mode - default: false --version, -v=VERSION Specify the PAServer tag to be used as image - default: latest --password, -pw=PWD Set the password - default: securepass --help, -h Display this help and exit * minor fix in the help * Simplify run.sh and add option to specify container name * chore: Update RAD Studio logo and README update * rewrite of the README.md * fix a few mixstakes in the readme * more fixes in the README.md * resize of embt images, abstracting links in the readme and minor fixes
checkdigits
approved these changes
Jul 24, 2024
checkdigits
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.