Fix blueish color inconsistencies #265
Conversation
|
@EliverLara can you check this please ? I can rebase afterward. |
|
If I rebase and correct the conflict can you merge this @EliverLara? |
There was a problem hiding this comment.
I think there is no need to change this file, since that variable doesn't alter any color so far
There was a problem hiding this comment.
This file shouldn't be changed due to the fact that it's the main color palette and shouldn't be altered
There was a problem hiding this comment.
That is a valid change but it could be improved a little bit by using the $fg_color variable instead of the hardcoded color value.
There was a problem hiding this comment.
This is not valid since those widget's color are independent from the theme accent color
There was a problem hiding this comment.
@aacebedo I'm sorry for the very late response but thank you so much for contributing! I have left you some feedback comments, I would really appreciate if you could tell me whether you want or not to apply those changes so I could work on them :)
Thanks for the review I am going to take a look. BTW I have a second PR with the same kind of modification to review. |
Fix some inconsistencies on blueish theme