Migrate annotations (old) (Sourcery refactored) #318
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| cropped_sign = annotation_elem.cropped_sign | ||
| if cropped_sign: | ||
| if cropped_sign := annotation_elem.cropped_sign: |
There was a problem hiding this comment.
Function CroppedAnnotationService.find_annotations_by_sign refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| [ | ||
| BoundingBox.from_relative_coordinates( | ||
| annotation.geometry.x, | ||
| annotation.geometry.y, | ||
| annotation.geometry.width, | ||
| annotation.geometry.height, | ||
| image_width, | ||
| image_height, | ||
| ) | ||
| for annotation in annotations | ||
| ] | ||
| BoundingBox.from_relative_coordinates( | ||
| annotation.geometry.x, | ||
| annotation.geometry.y, | ||
| annotation.geometry.width, | ||
| annotation.geometry.height, | ||
| image_width, | ||
| image_height, | ||
| ) | ||
| for annotation in annotations |
There was a problem hiding this comment.
Function BoundingBox.from_annotations refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
| assert [document for document in collection.find_many({"data": "payload"})] == [ | ||
| assert list(collection.find_many({"data": "payload"})) == [ |
There was a problem hiding this comment.
Function test_find_many refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| assert list(collection.find_many({})) == [] | ||
| assert not list(collection.find_many({})) |
There was a problem hiding this comment.
Function test_find_many_document_not_found refactored with the following changes:
- Replaces an empty collection equality with a boolean operation (
simplify-empty-collection-comparison)
| assert [ | ||
| document for document in collection.aggregate([{"$match": {"data": "payload"}}]) | ||
| ] == [document_match1, document_match2] | ||
| assert list(collection.aggregate([{"$match": {"data": "payload"}}])) == [ | ||
| document_match1, | ||
| document_match2, | ||
| ] |
There was a problem hiding this comment.
Function test_aggregate refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.07%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #317 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
migrate_annotationsbranch, then run:Help us improve this pull request!