Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle nested hydration better #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eight04
Copy link
Contributor

@eight04 eight04 commented Nov 9, 2022

Fixes #244

With this PR, you can nest hydrate-client={props} directive. Elderjs converts them into {...props} automatically if hydration is not applicable.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #258 (77e4d5c) into master (6d2cd15) will increase coverage by 0.10%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   81.30%   81.40%   +0.10%     
==========================================
  Files          47       47              
  Lines        2054     2060       +6     
  Branches      463      466       +3     
==========================================
+ Hits         1670     1677       +7     
+ Misses        382      381       -1     
  Partials        2        2              
Impacted Files Coverage Δ
src/rollup/rollupPlugin.ts 75.20% <75.00%> (+0.09%) ⬆️
src/partialHydration/inlineSvelteComponent.ts 100.00% <100.00%> (ø)
src/partialHydration/mountComponentsInHtml.ts 88.23% <100.00%> (+4.02%) ⬆️
src/partialHydration/partialHydration.ts 100.00% <100.00%> (ø)
src/utils/Page.ts 88.18% <100.00%> (ø)
src/utils/svelteComponent.ts 93.93% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle hydration inside hydration (resolve nested hydration)
2 participants