Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Active Model Serializer #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Support Active Model Serializer #18

wants to merge 2 commits into from

Conversation

PedroAugustoRamalhoDuarte
Copy link

@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte commented Jan 21, 2024 •
edited
Loading

Description 📖

Support Active Model Serializer

Background 📜

This gem have a big potencial to be the like the rack for translating types from ruby serializer to TypeScript.

The Fix 🔨

This PR introduces a new method, a new method prepare_attributes (with the same api from OJ Serializers) for AMS to make possible to run with types_from_serializers.

TODOs

  • Improve test duplicated code
  • Make more tests
  • Make work without explicit object_as for AMS
  • Test with type API works
  • Check if we can remove oj_serializer from depedencies, and AMS as well from test dependencies.
  • Changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PedroAugustoRamalhoDuarte