-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormData
and FormDataFromSelf
#4011
base: next-minor
Are you sure you want to change the base?
FormData
and FormDataFromSelf
#4011
Conversation
🦋 Changeset detectedLatest commit: edc9cdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cc @gcanti specifically for input here |
bbe0673
to
873afc2
Compare
9e8c8d0
to
c7975a4
Compare
873afc2
to
60a8222
Compare
e882714
to
7e81971
Compare
.changeset/rare-ducks-wait.md
Outdated
"effect": minor | ||
--- | ||
|
||
`FormData` and `FormDataFromSelf` have benn added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been
a60b469
to
396c9bd
Compare
packages/effect/src/Schema.ts
Outdated
fieldsTypes.arrays.forEach((arrayFieldKey) => (obj[arrayFieldKey] = [])) | ||
|
||
fd.forEach((value, key) => { | ||
if (typeof value !== "string") return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also handle File / Blob instances.
3f5cf6b
to
5c39db6
Compare
6e9ea20
to
84b3bd7
Compare
8dfabca
to
c341aad
Compare
Type
Description
I tried to solve this issue #3986
the interesting part was that when encoding, information about an empty array is lost - I solved this using ast-based parsing - I'm not sure if this is the right or complete solution
Related
Schema.FormData
literal to work with 3rd party libs that expose only it #3986