Updates MVK test to be configured through testmod #4618
Conversation
|
TODO:
|
|
You can preview documentation at https://esmci.github.io/cime/branch/update-mvk-config/html/index.html |
|
New relevant doc section https://esmci.github.io/cime/branch/update-mvk-config/html/users_guide/testing.html#system-test-mods |
|
@mkstratos please review. |
CIME/SystemTests/mvk.py
Outdated
| ) | ||
| self._set_attribute("ninst", 30, "The number of instances.") | ||
| self._set_attribute( | ||
| "critical", 13, "The critical value for rejecting the null hypothese." |
There was a problem hiding this comment.
EVV no longer needs this as of v0.5.0, (implemented false discovery rate correction), but that's my fault as it's not fully documented! It won't cause an error, but it isn't used by evv's ks.py
CIME/SystemTests/mvk.py
Outdated
| evv_lib_dir = os.path.abspath(os.path.dirname(evv4esm.__file__)) | ||
| version = evv4esm.__version_info__ | ||
|
|
||
| assert version[0] <= 0 and version[1] <= 5, "Please install evv4esm less than 0.5.x" |
There was a problem hiding this comment.
This would need updating each time there's a new EVV version, maybe this should be a lower bound instead, all the changes are compatible with evv4esm >= 0.5.0
CIME/SystemTests/mvk.py
Outdated
| set_nml_variable("seed_custom", f"{iinst}") | ||
| set_nml_variable("seed_clock", ".true.") | ||
|
|
||
| def test_config( |
There was a problem hiding this comment.
Could this instead be called test_config_evv? That way it's clear that this method is for creating the configuration to be passed to evv4esm?
doc/source/users_guide/testing.rst
Outdated
| component str The main component. | ||
| components [] list Components that require namelist customization. | ||
| ninst 30 int The number of instances. | ||
| critical 13 int The critical value for rejecting the null hypothese. |
There was a problem hiding this comment.
Same comment as on mvk.py, just that I didn't document this (yet!).
|
@mkstratos Thanks for the feedback, it looks great. |
Updates MVK systemtest to be configure through a testmod. Add a
param.pyfile in the testmod directory. Runningpython -c "from CIME.SystemTests.mvk import MVKConfig; MVKConfig().print_rst_table()will print out documentation for the settings/functions.
Test suite: n/a
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a
Fixes #4592
User interface changes?:
Update gh-pages html (Y/N)?: