Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZHA event data to what ZHA provides in HA 2024.03.01 #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ogajduse
Copy link

@ogajduse ogajduse commented Mar 23, 2024

Breaking change

Breaking changes for older HA versions, ZHA respectively that do not emit two extra zeros in the event args for each button action

Proposed change

This PR fixes args for all available actions of the Ikea E1744 button. The new ZHA version adds two zeros at the end of the args list. This PR adapts the controller automation to the change. Fixes #533

I have also made the regex lazier around whitespace since the output of the sensor last_controller_event is a pretty formatted JSON.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

Hey @ogajduse, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@ogajduse ogajduse force-pushed the fix/ikea-e1744-zha-events branch from 4c08c7d to cb601c8 Compare March 27, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IKEA E1744 SYMFONISK Rotary Remote does not change Homepod volume using rotate
1 participant