Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZHA long press buttons mapping for ikea_e1743.yaml #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomekskuta
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

I changed mapped action names for long press and for releasing long press. I did it because these actions with current blueprint didn't work because of wrong action names. Made the change only for ZHA.
New actions maps:

  • button_up_long: move_with_on_off_MoveMode.Up_83
  • button_up_release: stop_with_on_off
  • button_down_long: move_MoveMode.Down_83_bitmap8.0_bitmap8.0
  • button_down_release: stop_with_on_off

The solution tested with 3 Ikea e1743 dimmers.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Change mapping for long press and releasing after long press actions.
Copy link
Contributor

Hey @tomekskuta, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@Roukanken42
Copy link

For some reason, my dimmers fire move_MoveMode.Down_83_0_0 event for the button_down_long, without the bitmap parts... Other events look consistent with your changes.

dtreskunov pushed a commit to dtreskunov/awesome-ha-blueprints that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants