-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Zigbee2MQTT command names in philips_324131092621.yaml #542
base: main
Are you sure you want to change the base?
Fix Zigbee2MQTT command names in philips_324131092621.yaml #542
Conversation
Command names for Hue Dimmer were using hypens for Zigbee2MQTT, where they should be underscores, like in ZHA.
Hey @RobertClarke64, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Thank you, your PRed version works well! |
I think someone should go ahead and merge this? |
@EPMatt Is this repository still maintained? Seems like quite a few people have benefited from this PR and it should probably be merged. |
This fix doesn't quite do it yet. zigbee2mqtt:
button_on_short: [on_press] but zigbee2mqtt:
button_on_short: [on_press_release] I'm currently preparing a PR to fix this and I will combine it with a few other fixes. |
I patched the blueprint in my environment and it worked! |
Command names for Hue Dimmer blueprint were using hypens for Zigbee2MQTT, where they should be underscores, like in ZHA. Fixes #541.
Proposed change
Fix the command names for Hue Dimmer switches connected using Zigbee2MQTT. The blueprint was expecting hyphens before, where it should be expecting underscores. This resulted in a broken blueprint.
Note that this change is already reflected in the blueprint for the Hue Dimmer v2 remote. I'm using the v1 remote and the commands use underscores.
Simply changes:
to this:
Checklist
npm run format
before submitting my Pull Request.^ no but I only swapped some hyphens for underscores :)