Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the IKEA E1744 controller #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

drsound
Copy link

@drsound drsound commented Feb 28, 2023

A functional issue with the Home Assistant ZHA blueprint was identified as a result of recent code changes. The root cause of this issue pertains to the modified format of the "args" values received by the blueprint. To address this, the issue has been resolved by retrieving the value of the first element of the "args", which is sufficient to determine the intended action. It should be noted that the "toggle" command does not have any "args". Therefore, an "if" statement has been implemented to handle this case.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

The technical description is in the commit comment itself, and I see it has been automatically pasted to the top of this pull request. No need to copy it here again.
Closes #334 and #423.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

A functional issue with the Home Assistant ZHA blueprint was identified as a result of recent code changes. The root cause of this issue pertains to the modified format of the "args" values received by the blueprint. To address this, the issue has been resolved by retrieving the value of the first element of the "args", which is sufficient to determine the intended action. It should be noted that the "toggle" command does not have any "args". Therefore, an "if" statement has been implemented to handle this case.
@github-actions
Copy link
Contributor

Hey @drsound, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@Misiu
Copy link

Misiu commented Apr 27, 2023

works perfectly :)
Thank you!
@EPMatt any chance this might get merged? I've tested it with HA 2023.4.6

@drsound
Copy link
Author

drsound commented May 2, 2023

Hi @EPMatt, would you please merge this PR? Thanks. I see the last merge is from August 2022...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Ikea E1744 left and right rotation not working anymore
3 participants