Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EICNET-3131 Community can not synchronise anymore the Taxonomy from the SMeDashboard #2222

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

EICNET-3131 Community can not synchronise anymore the Taxonomy from the SMeDashboard #2222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83a9224
EICNET-3131: 1st refactor of the class, since we are using migrate_pl…
Sep 12, 2024
43097f7
EICNET-3131: Updated patch to a more recent version, for migrate_plus.
Sep 12, 2024
ab79912
EICNET-3131: Updated softcreatr/jsonpath (php 8.x compatible) used in…
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"minimum-stability": "dev",
"prefer-stable": true,
"require": {
"php": ">=7.4",
"php": ">=8.0",
"ext-json": "*",
"amsul/pickadate_js": "^3.6",
"ckeditor/colorbutton": "^4.18",
Expand Down Expand Up @@ -118,7 +118,7 @@
"openeuropa/oe_media": "^1.13",
"openeuropa/oe_time_caching": "^1.1",
"openeuropa/oe_webtools": "^1.13",
"softcreatr/jsonpath": "^0.7.5",
"softcreatr/jsonpath": "^0.8",
"twig/twig": "2.15.3 as 1.44.2",
"webflo/drupal-finder": "^1.2",
"webmozart/path-util": "^2.3",
Expand Down
21 changes: 10 additions & 11 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion composer.patches.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"3134245 - Run drush imports as user=1" : "https://www.drupal.org/files/issues/2020-05-06/3134245.patch"
},
"drupal/migrate_plus": {
"3007709 - Add XPath-style filtering ability in JSON data parser plugin" : "https://www.drupal.org/files/issues/2020-11-16/migrate_plus-json-xpath-filtering-3007709-24.patch"
"3007709 - Add XPath-style filtering ability in JSON data parser plugin (up to date with version ^6.0.x)" : "https://www.drupal.org/files/issues/2022-10-28/migrate_plus-json-xpath-filtering-3007709-40.patch"

},
"drupal/publication_date": {
"#3066317 - Provide computed properties that return the publication date or the created/updated date": "https://www.drupal.org/files/issues/2019-07-07/3066317-3.patch",
Expand Down
4 changes: 2 additions & 2 deletions lib/modules/eic_webservices/src/Plugin/migrate_plus/data_fetcher/EicHttpSmedTaxonomyPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Drupal\migrate\MigrateException;
use Drupal\migrate_plus\Plugin\migrate_plus\data_fetcher\Http;
use GuzzleHttp\Exception\RequestException;

use Psr\Http\Message\ResponseInterface;
/**
* Retrieve data over a SMED API HTTP connection for migration.
*
Expand Down Expand Up @@ -34,7 +34,7 @@ class EicHttpSmedTaxonomyPost extends Http implements ContainerFactoryPluginInte
/**
* {@inheritdoc}
*/
public function getResponse($url) {
public function getResponse($url): ResponseInterface {
try {
// First check if we have vocabulary ID to query on.
if (empty($this->configuration['taxonomy_vocabulary_smed_id'])) {
Expand Down