Skip to content

Commit

Permalink
EICNET-2948: EICNET-2948 (#2168)
Browse files Browse the repository at this point in the history
* EICNET-2948: update php to 8.1

* EICNET-2948: add return types to methods
  • Loading branch information
dimitriskr committed Mar 5, 2024
1 parent 69948d1 commit 967ce06
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docker/php/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG PHP_VERSION=7.4
ARG PHP_VERSION=8.1
ARG COMPOSER_VERSION=1

FROM composer:${COMPOSER_VERSION} AS composer
Expand Down
8 changes: 4 additions & 4 deletions lib/themes/eic_community/src/ValueObject/ValueObjectBase.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,28 @@ abstract class ValueObjectBase implements ValueObjectInterface {
/**
* {@inheritdoc}
*/
public function offsetExists($offset) {
public function offsetExists($offset): bool {
return array_key_exists($offset, $this->getArray());
}

/**
* {@inheritdoc}
*/
public function offsetGet($offset) {
public function offsetGet($offset): mixed {
return $this->getArray()[$offset];
}

/**
* {@inheritdoc}
*/
public function offsetSet($offset, $value) {
public function offsetSet($offset, $value): void {
// Does nothing as a value object array access is meant to be read-only.
}

/**
* {@inheritdoc}
*/
public function offsetUnset($offset) {
public function offsetUnset($offset): void {
// Does nothing as a value object array access is meant to be read-only.
}

Expand Down

0 comments on commit 967ce06

Please sign in to comment.