-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fetch Test Rubric
https://github.com/EFForg/https-everywhere-full-fetch-test
git clone https://github.com/EFForg/https-everywhere-full-fetch-test.git
sudo docker build -t httpse-fetch .
To log into container while process is running:
docker exec -it <containerid> /bin/bash
-
Update the cipher list in https://github.com/EFForg/https-everywhere/blob/c7da7b7eb704a697cc3d44e406c1912e45b954a9/test/rules/src/https_everywhere_checker/http_client.py#L48-L49 with ciphers from an updated version of Firefox ESR (https://github.com/EFForg/https-everywhere/pull/18964)
-
Create an issue (or send an email) announcing that there will be a forthcoming run of the full fetch test
-
Update certificate bundle:
https://github.com/EFForg/https-everywhere/blob/master/utils/create-platform-certs/README.md
-
Update Tor Browser User agent in
http.checker.config
Example: https://github.com/EFForg/https-everywhere/pull/19004
-
Make sure Allowlist is up to date and accounts for onions especially
-
git checkout -b patch
-
git format-patch master --stdout > /patch/diff.patch
Use SplitPatch to parse each patch individually if needed
https://github.com/benjsc/splitpatch
sudo apt-get install splitpatch
-
scp
Patch File from server - Apply patch file to patch branch locally
git apply --check patch
git apply patch
- Amend test coverage and lingering ruleset reference
Maintainers
Code of Conduct:
https://www.eff.org/pages/eppcode
Sample Responses
https://github.com/EFForg/https-everywhere/wiki/New-Maintainers:-Sample-Responses-for-Maintainers
Helpful Pull Request Queries
https://github.com/EFForg/https-everywhere/wiki/New-Maintainers:-Helpful-Pull-Request-Search-Queries