particleGridMigrate -> particleMigrate (Update to latest Cabana)
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, that deprecation wrapper should just emit a warning, but my return type mistake broke it. We should still replace it here - can you update this branch with formatting? |
|
Sure, can you please give me couple of days? I will setup formatting in my system and push as soon as I can. |
|
@streeve please drop my PR if it is needed and go ahead with your changes. As this is blocking. |
|
This is only failing because it doesn't use the most up to date Cabana in the CI. With the recent change in Cabana, ExaMPM should work with a warning (I don't believe this is blocking anything) |
|
Ohh okay. Thanks for the clarification. |
streeve
force-pushed
the
master
branch
2 times, most recently
from
48ba503
to
9bf44bf
Compare
streeve
changed the title
particleGridMigrate -> particleMigrate (Update to latest Cabana)particleGridMigrate -> particleMigrate (Update to latest Cabana)
streeve
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the build fails due to a function mismatch:
Cabana::Grid::particleGridMigrate.This is updated to:
Cabana::Grid::particleMigrate.Fixes #60