i#2498 init failures: Ignore privlib init failures #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates DR to 51b152fa2 extends the private loader bcrypt.dll entry failure being ignored to ignore all private library entry failures. We have had multiple cases of initializers failing without fatal consequences, and given that we do not have resources to track down every detail it is best to note the failure and move on. We have seen Dr. Memory in particular fail on newer Windows versions and in some cases ignoring that failure lets the tool continue and succeed, as only a small piece of the private library is needed (generally pulled in as a chain of dependences from dbghelp.dll which is used for symbol information). The private loader on Windows is considered best-effort at this point. Issue: #2498
|
The failures are the vsyscall ones from Github switching to AMD: #2491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates DR to 51b152fa2 extends the private loader bcrypt.dll entry failure being ignored to ignore all private library entry failures. We have had multiple cases of initializers failing without fatal consequences, and given that we do not have resources to track down every detail it is best to note the failure and move on. We have seen Dr. Memory in particular fail on newer Windows versions and in some cases ignoring that failure lets the tool continue and succeed, as only a small piece of the private library is needed (generally pulled in as a chain of dependences from dbghelp.dll which is used for symbol information). The private loader on Windows is considered best-effort at this point.
Issue: #2498