Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SA1141 #3610

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Mar 6, 2023

  • Avoid all work on compilations that don't support tuples (not a common case)
  • Check identifier names before calling GetSymbolInfo

This is a partial resolution of the issue that led to #3609. Note that the new behavior for handling ValueTuple.Create will not work correctly in cases where users have a using alias directive like the following:

using VT = System.ValueTuple;

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #3610 (292191a) into master (50610bc) will increase coverage by 0.08%.
The diff coverage is 98.50%.

❗ Current head 292191a differs from pull request most recent head f254f73. Consider uploading reports for the commit f254f73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
+ Coverage   93.25%   93.33%   +0.08%     
==========================================
  Files        1077     1078       +1     
  Lines      113670   113615      -55     
  Branches     4019     4011       -8     
==========================================
+ Hits       106002   106043      +41     
+ Misses       6633     6547      -86     
+ Partials     1035     1025      -10     

@@ -0,0 +1,11 @@
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with these missing test classes. I assume it was a mistake to not add them earlier. Would be good to have automated checks for things like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants