-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct property standard text for ru-RU culture #3335
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,16 +139,16 @@ | |
<value /> | ||
</data> | ||
<data name="StartingTextGets" xml:space="preserve"> | ||
<value>Получает</value> | ||
<value>Возвращает</value> | ||
</data> | ||
<data name="StartingTextGetsOrSets" xml:space="preserve"> | ||
<value>Получает или задает</value> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 This change is consistent with an example page I found: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can open any list of properties and see, that summary almost of all of them starts with "Возвращает", e.g. PS: I noticed that "Получает" often occures where machine translation is used. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As another argument, can say, that "Получает" is more likely "takes", but for property it is more likely "gives" which is "Возвращает". |
||
<value>Возвращает или задает</value> | ||
</data> | ||
<data name="StartingTextGetsOrSetsWhether" xml:space="preserve"> | ||
<value>Получает или задает значение, показывающее,</value> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
StyleCop Analyzers currently uses There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't focussed on it, so can't say anything about. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
But I haven't looked looked at the context, so it might be slightly incorrect |
||
<value>Возвращает или задает значение, показывающее,</value> | ||
</data> | ||
<data name="StartingTextGetsWhether" xml:space="preserve"> | ||
<value>Получает значение, показывающее,</value> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
StyleCop Analyzers currently uses |
||
<value>Возвращает значение, показывающее,</value> | ||
</data> | ||
<data name="StartingTextSets" xml:space="preserve"> | ||
<value>Задает</value> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.microsoft.com/ru-ru/dotnet/api/system.windows.forms.control.accessibilityobject?view=netframework-4.8
However, this change is consistent with a different example page from the same type:
https://docs.microsoft.com/ru-ru/dotnet/api/system.windows.forms.control.preferredsize?view=netframework-4.8
Do we need to support both, or does the documentation for my first link need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I know, in most part of documentaion exatly "Возвращает" is used. Also, when we used StyleCop extension for earlier versions of VS, exactly "Возвращает" was correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here an example of developer manual, which says that standard text for properties must starts with "Возвращает" or "Возвращает или задает":
https://terralink-xde.readthedocs.io/ru/develop/developer/CodingGuidelines/CodingGuidelines-XmlDocs.html