Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Support async Main methods #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Aug 6, 2018

Fixes #66

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #72 into master will increase coverage by 0.12%.
The diff coverage is 86.79%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   81.54%   81.66%   +0.12%     
==========================================
  Files          38       38              
  Lines        2943     2995      +52     
  Branches      188      196       +8     
==========================================
+ Hits         2400     2446      +46     
- Misses        444      448       +4     
- Partials       99      101       +2
Impacted Files Coverage Δ
...geAnalyzers.Test/Naming/UseAsyncSuffixUnitTests.cs 100% <100%> (ø) ⬆️
...yncUsageAnalyzers/Naming/UseAsyncSuffixAnalyzer.cs 100% <100%> (ø) ⬆️
...ncUsageAnalyzers/Helpers/MethodSymbolExtensions.cs 76.54% <72%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e1d22...9a4f3fa. Read the comment docs.

@jeremyVignelles
Copy link

Is there any reason why it's not merged yet?

@sharwell
Copy link
Member Author

@jeremyVignelles This project is pretty far behind on state-of-the-art. I'm working with @AArnott to determine if the package should be retired over the next few months in favor of Microsoft.VisualStudio.Threading.Analyzers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants