Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to docs about remote debugging #725

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

CherryDT
Copy link
Contributor

As discussed in #639

FAQ entry about remote debugging, modification of "future work" entry accordingly.

@Domiii
Copy link
Owner

Domiii commented Apr 24, 2022

hi @CherryDT
Sorry for the delay - had a few big things happening the past week.
I already reviewed the PR. Looks good to me.

As you can see, there are now conflicts. That was a general problem because yarn docs:build would write to the deployment folder (which has been updated since and thus is conflicting). I fixed that. If you check out the latest master, yarn docs:build will now build to a gitignore'd folder instead, and you will not conflict with deployment results anymore.

Your easiest way to fix this is to git reset the docs folder (e.g. git reset --hard -- docs), and then pull master, you should be good.

Apologies for the annoyance!

@Domiii
Copy link
Owner

Domiii commented Apr 24, 2022

Also, if you have any questions or want to talk about Dbux in general, feel free to reach out to me on Discord and feel free to DM me directly. We can even jump into a voice call and look at your stuff (or other Dbux stuff) together, if you want to.
We are currently in the early stages, and I want to make sure to reach out to anyone who puts in any amount of time, such as yourself :)

@CherryDT
Copy link
Contributor Author

CherryDT commented Apr 28, 2022

Did that (however I had to do rm -rf docs; git checkout upstream/master -- docs; git add docs; git commit; git merge upstream/master). But I don't see docs being in .gitignore now either...

@Domiii
Copy link
Owner

Domiii commented Apr 29, 2022

docs is the built and deployed folder. I re-build it when running the deploy command.

However, the build command is now using a different folder, as you can see here. That's why .gitignore did not need that change.

@Domiii Domiii merged commit 48a334c into Domiii:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants