Color struct refactor #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor for the
Colorstruct and implementation for the reader/writerTasks done in this PR
This feature will be finished in the follow PR:
Investigation
This are some controlled values found in the dwg while using the method
ReadCmColor()Dxf values are in decimal | hex | bin
DXF { Code: 62 Value: 80 | 0x50 | 0b0101_0000 }
rgb = 0xC3000050;
rgb_bin = 0b1100_0011_0000_0000_0000_0000_0101_0000
DXF { Code: 62 Value: 150 | 0x96 | 0b1001_0110 }
DXF { Code: 420 Value: 1151726 | 0x1192EE | 0b0101_0000 }
rgb = 0xC21192EE;
rgb_bin = 0b1100_0010_0001_0001_1001_0010_1110_1110 //420 value
DXF { Code: 62 Value: 31 | 0x1F | 0b0001_1111 }
DXF { Code: 420 Value: 16564615 | 0xFCC187 | 0b1111_1100_1100 0001_1000_0111 }
DXF { Code: 430 Value: DIC COLOR GUIDE(R)$DIC 7 }
rgb = 0xFCC187;
rgb_bin = 0b1100_0010_1111_1100_1100_0001_1000_0111 //420 value
Bit 0x1000000 seems to be the true color flag