feat: add alert when db is detected and allow to split into dedicated db service #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "Add Database" reuses the AddDatabase Component used in the AddServices Dropdown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to
apps/dokploycomponents and pages to enhance the user interface and functionality, particularly related to dropdown menus and database service alerts. The most important changes include importing new components, modifying existing components to useDropdownMenuItem, and adding alerts for database services.Component Imports and Updates:
apps/dokploy/components/dashboard/compose/delete-compose.tsx: Added import forDropdownMenuItemand modifiedDeleteComposeto useDropdownMenuIteminstead ofButton. [1] [2]apps/dokploy/components/dashboard/compose/update-compose.tsx: Added import forDropdownMenuItemand modifiedUpdateComposeto useDropdownMenuIteminstead ofButton. [1] [2]Additional Props and Dynamic Text:
apps/dokploy/components/dashboard/project/add-database.tsx: AddeddropdownItemNameprop toAddDatabasecomponent and used it to dynamically set the text in the dropdown menu item. [1] [2]Page Enhancements:
apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsx: Added imports for various UI components and icons, added a check for database services in the compose file, and displayed an alert if a database service is detected. Additionally, integratedAddDatabaseinto the dropdown menu. (apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxR11-R28, apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxL32-R56, apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxR74, apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxR89-R92, apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxR125-R136, apps/dokploy/pages/dashboard/project/[projectId]/services/compose/[composeId].tsxL221-R281)This should fix https://github.com/orgs/Dokploy/projects/3/views/2?pane=issue&itemId=86318533&issue=Dokploy%7Cdokploy%7C187