Avoid setAttribute for CSP compliance #6357
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Under some circumstances (we experienced this issue with a recent rails and appropriately strict CSP policies, see mkhairi/materialize-sass#186), materialize causes CSP violations.
Using
setAttribute('style', style)
causes issues with the style policy.element.style = ...
is CSP compliant and could be used instead. jQuery offers.css()
, which uses the aforementioned.style
.This PR changes the problematic
setAttribute
calls to using asetStyle()
function which checks if jQuery is loaded and uses.css()
if possible or falls back tosetAttribute
.It might be possible to enhance the function to fall back to looping through the styles and directly applying them with
.style =
, but I didn't look into that yet.I "played it safe" with regards to the jQuery check, but maybe
.css()
is already implemented by whichever way materialize chose to replace/deprecate jQuery, so it might not even be necessary.Screenshots (if appropriate) or codepen:
/
Types of changes
Checklist: