Merge pull request #84 from DigiChanges/feat/LC/add-lint-rules

feat: update eslint dependencies and add eslint rules
DigiChanges · Feb 17, 2022 · d5c0ee9 · d5c0ee9
2 parents 51eac50 + 89d3921
commit d5c0ee9
Show file tree

Hide file tree

Showing 66 changed files with 238 additions and 324 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -28,7 +28,15 @@ module.exports = {
     ],
     'rules': {
         indent: 'off',
-        '@typescript-eslint/indent': ['error', 4],
+        '@typescript-eslint/indent': ['error', 4,
+          {
+            "ignoredNodes": [
+              "FunctionExpression > .params[decorators.length > 0]",
+              "FunctionExpression > .params > :matches(Decorator, :not(:first-child))",
+              "ClassBody.body > PropertyDefinition[decorators.length > 0] > .key"
+            ]
+          }
+        ],
         'quotes': ['warn', 'single'],
         'semi': ['warn', 'always'],
         'semi-spacing': ['warn', {'before': false, 'after': true}],
@@ -43,6 +51,8 @@ module.exports = {
         'space-before-function-paren': ['warn', 'never'],
         'keyword-spacing': ['warn', {'before': true}],
         'linebreak-style': ['error', 'unix'],
+        "padded-blocks": ["error", "never"],
+        "eol-last": ["error","always"],
         'brace-style': ['error', 'allman'],
         'prefer-const': ['warn'],
         'max-len': [
@@ -133,7 +143,8 @@ module.exports = {
         '@typescript-eslint/ban-ts-comment': 0,
         '@typescript-eslint/no-unsafe-call': 0,
         '@typescript-eslint/require-await': 0,
+        "@typescript-eslint/type-annotation-spacing": "warn",
+        "@typescript-eslint/no-unsafe-argument": "warn",
         'no-mixed-spaces-and-tabs': 0
     }
 };
-
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "cors": "^2.8.5",
     "dotenv": "^8.2.0",
     "envalid": "^7.2.1",
-    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-import": "^2.25.4",
     "eslint-plugin-prefer-arrow": "^1.2.3",
     "express": "^4.17.1",
     "express-handlebars": "^5.3.0",
@@ -156,11 +156,11 @@
     "@types/uuid": "^8.3.0",
     "@types/validator": "^13.7.0",
     "@types/web-push": "^3.3.0",
-    "@typescript-eslint/eslint-plugin": "^4.33.0",
-    "@typescript-eslint/parser": "^4.33.0",
+    "@typescript-eslint/eslint-plugin": "^5.10.2",
+    "@typescript-eslint/parser": "^5.10.2",
     "concurrently": "^6.3.0",
     "cpy-cli": "^3.1.1",
-    "eslint": "^7.32.0",
+    "eslint": "^8.8.0",
     "husky": "^7.0.4",
     "jest": "^27.4.5",
     "lint-staged": "^11.2.6",

diff --git a/src/App/Infrastructure/Repositories/RedisCacheRepository.ts b/src/App/Infrastructure/Repositories/RedisCacheRepository.ts
@@ -83,4 +83,4 @@ class RedisCacheRepository implements ICacheRepository
     }
 }
 
-export default RedisCacheRepository;
+export default RedisCacheRepository;
diff --git a/src/App/InterfaceAdapters/IByOptions.ts b/src/App/InterfaceAdapters/IByOptions.ts
@@ -2,8 +2,8 @@ import { PopulateOptions } from 'mongoose';
 
 interface IByOptions
 {
-    initThrow? : boolean | undefined;
+    initThrow?: boolean | undefined;
     populate?: string | PopulateOptions | PopulateOptions[] | undefined;
 }
 
-export default IByOptions;
+export default IByOptions;
diff --git a/src/App/InterfaceAdapters/IId.ts b/src/App/InterfaceAdapters/IId.ts
@@ -3,4 +3,4 @@ interface IId
     _id?: string | any;
 }
 
-export default IId;
+export default IId;
diff --git a/src/App/InterfaceAdapters/IKind.ts b/src/App/InterfaceAdapters/IKind.ts
@@ -3,4 +3,4 @@ interface IKind
     king: string;
 }
 
-export default IKind;
+export default IKind;
diff --git a/src/App/Presentation/Shared/ErrorHttpException.ts b/src/App/Presentation/Shared/ErrorHttpException.ts
@@ -18,7 +18,7 @@ class ErrorHttpException extends Error
         this._metadata = metadata;
     }
 
-    public get statusCode() : IStatusCode
+    public get statusCode(): IStatusCode
     {
         return this._statusCode;
     }
@@ -28,7 +28,7 @@ class ErrorHttpException extends Error
         this._statusCode = value;
     }
 
-    public get errors() : ValidationError[]
+    public get errors(): ValidationError[]
     {
         return this._errors;
     }
@@ -38,7 +38,7 @@ class ErrorHttpException extends Error
         this._errors = err;
     }
 
-    public get metadata() : Record<string, any>
+    public get metadata(): Record<string, any>
     {
         return this._metadata;
     }

diff --git a/src/App/Tests/index.handler.spec.ts b/src/App/Tests/index.handler.spec.ts
@@ -13,14 +13,12 @@ describe('Start Index Test', () =>
 
         request = configServer.request;
         dbConnection = configServer.dbConnection;
-
     });
 
     afterAll((async() =>
     {
         await dbConnection.drop();
         await dbConnection.close();
-
     }));
 
     describe('#get', () =>
@@ -29,7 +27,6 @@ describe('Start Index Test', () =>
         {
             const response: any = await request.get('/');
             expect(response.statusCode).toStrictEqual(200);
-
         });
     });
 });
diff --git a/src/App/Tests/whiteList.handler.spec.ts b/src/App/Tests/whiteList.handler.spec.ts
@@ -13,14 +13,12 @@ describe('White list routes Test', () =>
 
         request = configServer.request;
         dbConnection = configServer.dbConnection;
-
     });
 
     afterAll((async() =>
     {
         await dbConnection.drop();
         await dbConnection.close();
-
     }));
 
     describe('all', () =>
@@ -29,35 +27,30 @@ describe('White list routes Test', () =>
         {
             const response: any = await request.get('/test/all/12345678');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('post', async() =>
         {
             const response: any = await request.post('/test/all/hello/world');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('put', async() =>
         {
             const response: any = await request.put('/test/all/numeric/123');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('delete', async() =>
         {
             const response: any = await request.delete('/test/all/12345678/delete');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('query', async() =>
         {
             const response: any = await request.get('/test/all/query?hola=mundo&hello=world');
             expect(response.statusCode).toStrictEqual(200);
-
         });
     });
 
@@ -67,48 +60,40 @@ describe('White list routes Test', () =>
         {
             const response: any = await request.get('/test/countries');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('query', async() =>
         {
             const response: any = await request.get('/test/countries?status=true');
             expect(response.statusCode).toStrictEqual(200);
-
         });
     });
 
     describe('dynamic', () =>
     {
-
         test('equal', async() =>
         {
             const response: any = await request.get('/test/countries/12345678');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('one', async() =>
         {
             const response: any = await request.get('/test/countries/12345678/states');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('two', async() =>
         {
             const response: any = await request.get('/test/countries/12345678/states/12345678/cities');
             expect(response.statusCode).toStrictEqual(200);
-
         });
 
         test('query', async() =>
         {
             const response: any = await request.get('/test/countries/12345678/states?status=true');
             expect(response.statusCode).toStrictEqual(200);
-
         });
-
     });
 
     describe('untidy', () =>
@@ -119,16 +104,13 @@ describe('White list routes Test', () =>
             {
                 const response: any = await request.get('/test/12345678/hello/all');
                 expect(response.statusCode).toStrictEqual(403);
-
             });
 
             test('query', async() =>
             {
                 const response: any = await request.get('/test/12345678/hello/all?status=true');
                 expect(response.statusCode).toStrictEqual(403);
-
             });
-
         });
 
         describe('dynamic', () =>
@@ -137,17 +119,13 @@ describe('White list routes Test', () =>
             {
                 const response: any = await request.get('/test/cities/12345678/countries/12345678/states');
                 expect(response.statusCode).toStrictEqual(403);
-
             });
 
             test('query', async() =>
             {
                 const response: any = await request.get('/test/cities/12345678/countries/12345678/states?status=true');
                 expect(response.statusCode).toStrictEqual(403);
-
             });
-
         });
-
     });
 });
diff --git a/src/Auth/Domain/Services/AuthService.ts b/src/Auth/Domain/Services/AuthService.ts
@@ -15,7 +15,7 @@ import MainConfig from '../../../Config/mainConfig';
 class AuthService
 {
     @containerFactory(REPOSITORIES.IUserRepository)
-    private userRepository: IUserRepository
+    private userRepository: IUserRepository;
 
     private config = MainConfig.getInstance();
 

diff --git a/src/Auth/Domain/Types/TypeAuth.ts b/src/Auth/Domain/Types/TypeAuth.ts
@@ -1,4 +1,4 @@
 
 declare type TypeAuth = 'authUser' | 'tokenDecode';
 
-export default TypeAuth;
+export default TypeAuth;
diff --git a/src/Auth/InterfaceAdapters/IGroupPermission.ts b/src/Auth/InterfaceAdapters/IGroupPermission.ts
@@ -5,4 +5,4 @@ interface IGroupPermission
     permissions: string[];
 }
 
-export default IGroupPermission;
+export default IGroupPermission;
diff --git a/src/Auth/Presentation/Controllers/AuthController.ts b/src/Auth/Presentation/Controllers/AuthController.ts
@@ -49,7 +49,7 @@ class AuthController
         return await useCase.handle(request, authUser);
     }
 
-    public async logout(tokenDecode:ITokenDecode): Promise<ILocaleMessage>
+    public async logout(tokenDecode: ITokenDecode): Promise<ILocaleMessage>
     {
         const useCase = new LogoutUseCase();
         return await useCase.handle(tokenDecode);

diff --git a/src/Auth/Tests/forgotPassword.handler.spec.ts b/src/Auth/Tests/forgotPassword.handler.spec.ts
@@ -25,7 +25,6 @@ describe('Start ForgotPassword Test', () =>
     {
         await dbConnection.drop();
         await dbConnection.close();
-
     }));
 
     describe('ForgotPassword Success', () =>

diff --git a/src/Auth/Tests/keepAlive.handler.spec.ts b/src/Auth/Tests/keepAlive.handler.spec.ts
@@ -14,14 +14,12 @@ describe('Start Keep Alive Test', () =>
 
         request = configServer.request;
         dbConnection = configServer.dbConnection;
-
     });
 
     afterAll((async() =>
     {
         await dbConnection.drop();
         await dbConnection.close();
-
     }));
 
     describe('Keep Alive Success', () =>
@@ -41,7 +39,6 @@ describe('Start Keep Alive Test', () =>
             const { body: { data } } = response;
 
             token = data.token;
-
         });
 
         test.skip('Keep Alive POST /', async() =>
@@ -59,7 +56,6 @@ describe('Start Keep Alive Test', () =>
             expect(statusCode).toStrictEqual('HTTP_CREATED');
 
             token = refreshToken;
-
         });
     });
 });

diff --git a/src/Auth/Tests/login.handler.spec.ts b/src/Auth/Tests/login.handler.spec.ts
@@ -13,7 +13,6 @@ describe('Start Login Test', () =>
 
         request = configServer.request;
         dbConnection = configServer.dbConnection;
-
     });
 
     afterAll((async() =>
@@ -42,7 +41,6 @@ describe('Start Login Test', () =>
 
         expect(data.user.email).toStrictEqual('[email protected]');
         expect(data.user.firstName).toStrictEqual('user');
-
     });
 
     test('Login SuperAdmin Success', async() =>
@@ -65,7 +63,6 @@ describe('Start Login Test', () =>
 
         expect(data.user.email).toStrictEqual('[email protected]');
         expect(data.user.firstName).toStrictEqual('Super');
-
     });
 
     test('Login SuperAdmin Wrong Credentials', async() =>
@@ -87,7 +84,6 @@ describe('Start Login Test', () =>
         expect(statusCode).toStrictEqual('HTTP_FORBIDDEN');
 
         expect(message).toStrictEqual('Error credentials.');
-
     });
 
     test('Login Operator unverified', async() =>
@@ -130,6 +126,5 @@ describe('Start Login Test', () =>
         expect(statusCode).toStrictEqual('HTTP_FORBIDDEN');
 
         expect(message).toStrictEqual('Your role is disable.');
-
     });
 });