Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DI] Resolve IMessageInspector2 Using Scope Resolver #982

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ankitkmrpatel
Copy link

----IMessageInsector2 is being Added as Scope Service, However, it is being resolve as Sington Service

@ankitkmrpatel ankitkmrpatel changed the title fix: Resolve IMessageInspector2 Using Scope Resolver fix: [DI] Resolve IMessageInspector2 Using Scope Resolver Dec 13, 2023
@andersjonsson
Copy link
Collaborator

Could you please update your branch from the latest "develop"? Needed to fix some things to make CI work

@ankitkmrpatel
Copy link
Author

Hi @andersjonsson

The CI/CD test for the pull request is encountering a fetch error. Would you mind re-running the test to resolve this issue?

Here is the specific fetch command that is causing the issue:
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/main/x86_64/APKINDEX.tar.gz

@andersjonsson
Copy link
Collaborator

Please update your branch with the latest "develop". I've fixed the issues there

@ankitkmrpatel
Copy link
Author

Thanks, I have pulled the latest changes from the 'develop' branch.

Hope this works!

@andersjonsson
Copy link
Collaborator

I think you pulled the changes from your own develop-branch, including the code for custom serializers.

@andersjonsson
Copy link
Collaborator

When I look at the code for resolving IMessageInspector2 I'm not sure that the changes make sense.

Since the serviceProvider is passed in to each invoke it should be resolved as registered. I suppose you have an indication that this isn't the case. What is the issue you are running into?

@ankitkmrpatel
Copy link
Author

ankitkmrpatel commented Feb 26, 2024

Hi @andersjonsson ,

Referring to commit [Git Hub Commit#58afbb9]](58afbb9), The IMessageInspector2 has been resolved as a scoped dependency.

As you mentioned, serviceProvider is passed into each invoke it should be resolved as registered. However, It is noted that the IMessageInspector2 has been registered as scoped but resolved as singleton.

Have changed from singleton di resolve to scope di resolve in src/SoapCore/SoapEndpointMiddleware.cs.

@ankitkmrpatel
Copy link
Author

Hi @andersjonsson

I hope you're doing well.

I wanted to check in and see if you've had a chance to look into the issue I sent over earlier. If you need any additional information, please let me know.

Regards;
Ankit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants