Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded toml_edit #81

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

ikrivosheev
Copy link
Contributor

@ikrivosheev ikrivosheev commented Nov 19, 2024

This is finished: #78
After merge: #80 the PR will be less

@ikrivosheev ikrivosheev force-pushed the feature/upgrade_toml_edit branch 2 times, most recently from bfc0f3d to ba31b74 Compare November 19, 2024 21:28
@jplatte
Copy link
Collaborator

jplatte commented Nov 19, 2024

Looks like this needs a rebase. Also, commit messages are usually written in imperative form (beginning with "Upgrade", not "Upgraded"), though I can fix things up when merging like I did for the previous two PRs.

@ikrivosheev
Copy link
Contributor Author

Looks like this needs a rebase. Also, commit messages are usually written in imperative form (beginning with "Upgrade", not "Upgraded"), though I can fix things up when merging like I did for the previous two PRs.

Thank you for the review! I'm not native English speaker. I changed commit message.

This was referenced Nov 19, 2024
@jplatte jplatte merged commit f504796 into DevinR528:main Nov 19, 2024
4 checks passed
@ikrivosheev ikrivosheev deleted the feature/upgrade_toml_edit branch November 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants