Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#46] 드롭 피드백 만들기 #48

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

poetic-form
Copy link
Collaborator

📝 작업 내용

  • 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

드랍 피드백 만들었어요
하면서 UI 아주 살짝 손봤습니다

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

모델에 새 프로퍼티를 넣었는데 @transient 넣으니까 뷰가 변하질 않아서 @Attribute(.ephemeral)로 넣으니까 저장 안 해주는 프로퍼티로 들어간대서 이거 썼어요

스크린샷 (선택)

Aug-08-2024 22-08-25

Lee Sihyeong added 3 commits August 8, 2024 22:04
- 모델에 transient가 안먹어서 다른거로 바꿈
- 뷰가 업데이트 됨에 따라 그래프가 움직여서 사이즈 조절 조금 들어감
@poetic-form poetic-form added the 🛠️Feat 기능 구현 label Aug 8, 2024
@poetic-form poetic-form self-assigned this Aug 8, 2024
@poetic-form poetic-form linked an issue Aug 8, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@daminoworld daminoworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Collaborator

@dbqls200 dbqls200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 -!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

드롭 피드백 만들기
3 participants