Handle expired Bungie tokens better from DIM Sync #10812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
force-pushed
the
dim-sync-tokens
branch
from
ddcb8c9
to
8ee93f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if your Bungie.net token is expired and you open DIM, we show a login page but also a notification and a red banner complaining about DIM Sync failing to load. This isn't useful - of course it can't load.
What happens is when DIM Sync goes to get the bungie token, and the token is expired or otherwise missing,
getTokenthrows aFatalTokenErrorwhich basically means "you have to log in". We were still saving this into theprofileLoadedError. This change just stops settingprofileLoadedErrorand gives up - when we log in we'll get a chance to try again.