Adding new optional utility properties #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up expanding this PR into three new optional properties:
onStart
- A function similar toonStop
allowing for custom behavior when recording starts.customMediaStream
- Instead of just passing in adeviceId
I opted to allow the user to pass in their ownMediaStream
for total control over what is recorded.stopStreamsOnStop
- The current default behavior is to stop the media streams when the recording stops. This flag preservers that behavior, but also allows the option to not stop streams when recording stops.