-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return Value type of WebTorrent client.get() #69619
Conversation
@TechQuery Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69619,
"author": "TechQuery",
"headCommitOid": "c6b4b7b7d1f4697c54284be70dd1087c1a1ac120",
"mergeBaseOid": "bfdcd1c2bad2ed372ebf698103824f4171e5e972",
"lastPushDate": "2024-05-15T18:07:31.000Z",
"lastActivityDate": "2024-06-17T22:20:46.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2024-06-17T19:22:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "webtorrent",
"kind": "edit",
"files": [
{
"path": "types/webtorrent/index.d.ts",
"kind": "definition"
}
],
"owners": [
"niieani",
"tlaziuk",
"gjuchault",
"cheeseandcereal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2024-06-17T19:21:34.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2113147370,
"ciResult": "pass"
} |
🔔 @niieani @tlaziuk @gjuchault @cheeseandcereal — please review this PR in the next few days. Be sure to explicitly select |
I find that But the latest When I use
|
Re-ping @niieani, @tlaziuk, @gjuchault, @cheeseandcereal: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @TechQuery. (Ping @niieani, @tlaziuk, @gjuchault, @cheeseandcereal.) |
@gabritto This PR is not okay, it's not a detail bug. This type package has been outdated for a long time from its upstream, so we need to regenerate the whole type definition from the latest source code. But I blocked by the issue shown above, I need help. |
Unfortunately |
Closing this as per #69619 (comment). |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.