New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sluggo] Add types for sluggo #69524
Conversation
@RDIL Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69524,
"author": "RDIL",
"headCommitOid": "e5b3266cb93e7b8cbccec6945b0064c7310d09ec",
"mergeBaseOid": "91f5d3ae829281a501fe1d9ff5a6e052468ddf99",
"lastPushDate": "2024-05-05T22:04:52.000Z",
"lastActivityDate": "2024-05-06T19:00:02.000Z",
"mergeOfferDate": "2024-05-06T17:20:07.000Z",
"mergeRequestDate": "2024-05-06T19:00:02.000Z",
"mergeRequestUser": "RDIL",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "sluggo",
"kind": "add",
"files": [
{
"path": "types/sluggo/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/sluggo/index.d.ts",
"kind": "definition"
},
{
"path": "types/sluggo/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/sluggo/sluggo-tests.ts",
"kind": "test"
},
{
"path": "types/sluggo/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"RDIL"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-05-06T17:19:26.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2094967812,
"ciResult": "pass"
} |
🔔 @RDIL — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
@RDIL: Everything looks good here. I am ready to merge this PR (at e5b3266) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Sluggo is a very fast, unicode aware slug generator.
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.