Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/jsdom] Make contentType less restrictive #69520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codershiba
Copy link
Contributor

Fixes #69511

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 4, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 14 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69520,
  "author": "codershiba",
  "headCommitOid": "2568dc45f1fa438df83fbbe7c7a66500bb21bfa5",
  "mergeBaseOid": "5650c99ad5376096f2f4ca0b257b78b231092296",
  "lastPushDate": "2024-05-04T18:41:45.000Z",
  "lastActivityDate": "2024-05-04T18:41:45.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jsdom",
      "kind": "edit",
      "files": [
        {
          "path": "types/jsdom/base.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "palmfjord",
        "ExE-Boss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2094343519,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/2568dc45f1fa438df83fbbe7c7a66500bb21bfa5/checks?check_suite_id=23444909927"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 4, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 4, 2024
@typescript-bot
Copy link
Contributor

Hey @codershiba,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @leonard-thieu @palmfjord @ExE-Boss — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 4, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 4, 2024
@typescript-bot
Copy link
Contributor

@codershiba The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package The CI failed When GH Actions fails Untested Change This PR does not touch tests
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants